Skip to content

Let Hugo's Node symlink check pass the public snapshot - #527

Merged
chalin merged 5 commits into
docsy:mainfrom
chalin:chalin-m24-example-node-allowread-2026-1014
Oct 16, 2026
Merged

chalin merged 5 commits into
docsy:mainfrom
chalin:chalin-m24-example-node-allowread-2026-1014

Conversation

@chalin

@chalin chalin commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator
  • Scope:
    • Retires the env override the maintainers' snapshot build has needed since 0.18.0
    • Homes the snapshot layouts and their rationale in CONTRIBUTING § Built-site snapshot
  • Out of scope:
    • Docsy's own docsy.dev/public symlink (its dev build runs no Node tool)
    • The Hugo upgrade post's wording for this symlink shape (guide feedback, routed separately)
    • _commit:public committing the surrounding repo when public is a plain directory (pre-existing; follow-up)
  • Validation, with HUGO_SECURITY_* unset:
    • Builds pass at the primary clone through the symlink and in a worktree with a symlink to the snapshot; each fails on Hugo's symlink check when its entry is dropped
    • Builds pass in a worktree with a plain public/, and in CI, where neither snapshot path exists

@chalin
chalin requested a review from a team October 14, 2026 14:38
@netlify

netlify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for goldydocs ready!

Name Link
🔨 Latest commit bc97380
🔍 Latest deploy log https://app.netlify.com/projects/goldydocs/deploys/6ad2381e65461f34062b4172
😎 Deploy Preview https://deploy-preview-527--goldydocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@chalin chalin changed the title Let Node tools read through the public snapshot symlink Let Hugo's Node symlink check pass the public snapshot Oct 16, 2026
@chalin
chalin merged commit 5f52a24 into docsy:main Oct 16, 2026
8 checks passed
@chalin
chalin deleted the chalin-m24-example-node-allowread-2026-1014 branch October 16, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant