Repository navigation
Changed merge and build status of a ticket to render as icons. - #314
Open
smallsaucepan wants to merge 1 commit into
Open
smallsaucepan wants to merge 1 commit into
smallsaucepan wants to merge 1 commit into
Conversation
…ved necessary Github API calls to the server side. Have kept existing client side JS functionality enabled for comparison during review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed merge and build status of a ticket to render as icons (new at top, current below):
Also moved Github API calls to the server side. Part of making the PR status query more reliable was using the Github graphql interface, which requires a Github token. Doing this on the client would have been difficult. Although this requires a token be set, it does eliminate the issue where the client side code would get rate limited due to the user's anonymity.
Have kept existing client side JS functionality enabled for comparison during review.
Fixes #308