Repository navigation
fix: check deploy_lambda() inputs before pushing the image - #59
Merged
Merged
Conversation
Malformed role or policy ARNs failed only after the slow ECR push, and a failed policy attach left the new role behind. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several input mistakes surfaced only after the slow ECR push, and some left resources behind.
deploy_lambda()checks the ARN format ofrole_arn(arn:aws…:iam::<12 digits>:role/…) andpolicy_arns(arn:aws…:iam::(aws|<12 digits>):policy/…) before any AWS call. A role name like"my-role"or a bare policy name now fails at once.create_lambda_exec_role(): when a policy can't be attached, the policies already attached are detached and the new role is deleted before the error is raised. If that cleanup fails too, a warning names the role left behind, and the original attach error is still raised.build_lambda(system_deps = character(0))is rejected instead of writingdnf -y installwith no packages.Related GitHub Issues and PRs
Are these changes tested?
Yes. New tests: malformed and missing ARNs fail before the ECR lookup; a failed attach detaches and deletes the role; a failed cleanup warns and keeps the attach error; an empty
system_depsis rejected. Existing tests now use well-formed ARNs.Are there any user-facing changes?
Yes.
deploy_lambda()rejects malformedrole_arnandpolicy_arns, andbuild_lambda()rejects an emptysystem_deps.Was AI used for this PR?
In accordance with the AI generation guidelines, please disclose whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
Checklist
fix:,feat:,docs:, ...); it becomes theNEWS.mdentry.air format .andjarl check ..devtools::document()if documentation changed.testthatunit tests totests/testthatfor any new functionality or fixed bug.Assisted-by: Claude Code