Skip to content

DQM, unit tests for waveforms.py - #404

Merged
jlenain merged 1 commit into
cta-observatory:mainfrom
alessandromontanari:dqm-waveforms-unit-tests
Nov 10, 2026
Merged

jlenain merged 1 commit into
cta-observatory:mainfrom
alessandromontanari:dqm-waveforms-unit-tests

Conversation

@alessandromontanari

Copy link
Copy Markdown
Contributor

test(src/nectarchain/dqm/tests): - test_waveforms.py: complete unit tests for waveforms.py, reaching coverage of 95%

The PR reaches 95% unit test coverage for mean_camera_display.py. The missing lines are 102, 110-114, and 121. As usual, line 102 is the else clause, which we'll address once we implement tests for the other event types. 110-114 and 121 are else clauses that aren't handled because no test runs have r0 False. I suggest merging the PR as is.

…ests for waveforms.py, reaching coverage of 95%
@alessandromontanari alessandromontanari self-assigned this Nov 6, 2026
@alessandromontanari alessandromontanari added the test Pull request that works specifically on unit tests label Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.78%. Comparing base (8d4ccfb) to head (724de5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   56.12%   56.78%   +0.66%     
==========================================
  Files          96       96              
  Lines       10448    10448              
==========================================
+ Hits         5864     5933      +69     
+ Misses       4584     4515      -69     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessandromontanari alessandromontanari changed the title DQM, unit tests for mean_camera_display.py DQM, unit tests for waveforms.py Nov 6, 2026

@jlenain jlenain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlenain
jlenain merged commit 091256d into cta-observatory:main Nov 10, 2026
52 of 59 checks passed
@jlenain
jlenain deleted the dqm-waveforms-unit-tests branch November 10, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Pull request that works specifically on unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants