Repository navigation
DQM, unit tests for waveforms.py - #404
Merged
jlenain merged 1 commit intoNov 10, 2026
Merged
Conversation
…ests for waveforms.py, reaching coverage of 95%
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 56.12% 56.78% +0.66%
==========================================
Files 96 96
Lines 10448 10448
==========================================
+ Hits 5864 5933 +69
+ Misses 4584 4515 -69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jlenain
approved these changes
Nov 9, 2026
jlenain
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @alessandromontanari !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(src/nectarchain/dqm/tests): - test_waveforms.py: complete unit tests for waveforms.py, reaching coverage of 95%
The PR reaches 95% unit test coverage for mean_camera_display.py. The missing lines are 102, 110-114, and 121. As usual, line 102 is the else clause, which we'll address once we implement tests for the other event types. 110-114 and 121 are else clauses that aren't handled because no test runs have r0 False. I suggest merging the PR as is.