Repository navigation
Conversation
…ete unit tests for mean_camera_display.py, reaching coverage of 95%
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 56.12% 56.83% +0.70%
==========================================
Files 96 96
Lines 10448 10448
==========================================
+ Hits 5864 5938 +74
+ Misses 4584 4510 -74 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jlenain
approved these changes
Nov 6, 2026
jlenain
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @alessandromontanari !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(src/nectarchain/dqm/tests): - test_mean_camera_display.py: complete unit tests for mean_camera_display.py, reaching coverage of 95%
The PR reaches unit test coverage 95% for
mean_camera_display.py. The missing lines are (139-143):which unfortunately is not covered by the data we use for the tests because self.r0 is False; and the usual (161-166):
which, anyway, will have to be removed once I address the TODO for all the processors. Therefore, I suggest to merge the PR as is.