Skip to content

Temperature dependent TRR tests - #385

Open
medha1996c wants to merge 19 commits into
cta-observatory:mainfrom
medha1996c:temp_dep2
Open

medha1996c wants to merge 19 commits into
cta-observatory:mainfrom
medha1996c:temp_dep2

Conversation

@medha1996c

@medha1996c medha1996c commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

This PR introduces a layer around different TRR tests, to be able to scan their results with varying external temperature conditions.

@medha1996c
medha1996c marked this pull request as draft September 18, 2026 11:29
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 1.63551% with 421 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.58%. Comparing base (7bdbab1) to head (2af9648).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...rr_verification_package/observation_temperature.py 0.00% 332 Missing ⚠️
...c/nectarchain/trr_verification_package/deadtime.py 2.17% 45 Missing ⚠️
.../nectarchain/trr_verification_package/linearity.py 6.06% 31 Missing ⚠️
...hain/trr_verification_package/charge_resolution.py 10.00% 9 Missing ⚠️
...chain/trr_verification_package/tools_components.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   47.54%   55.58%   +8.04%     
==========================================
  Files          92       97       +5     
  Lines        9487    10815    +1328     
==========================================
+ Hits         4511     6012    +1501     
+ Misses       4976     4803     -173     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlenain jlenain added the enhancement New feature or request label Sep 21, 2026
- deadtime.py: refactor script to make run work with trr, av, and observation_temperature.py

- observation_temperature.py: refactor to get input from deadtime.py
@alessandromontanari

Copy link
Copy Markdown
Contributor

Hi @jlenain and @medha1996c, in the last commit, I refactored deadtime.py to make it work with the TRR and AV GUIs, as a standalone script, and in observation_temperature.py (in principle). For the last one, I'm not sure yet because I'm missing one input file that Medha should push.
I tested both the TRR and AV GUI locally, with only two runs, and they work. I don't think the PR is ready for review yet, but I think I can polish the latest details over the next few days.

@alessandromontanari

Copy link
Copy Markdown
Contributor

Hi @medha1996c and @jlenain, I tested deadtime locally with both the AV and TRR GUI, and it always works as intended. I also ran the corresponding module in observation_temperature.py, and it works there as well. At least for the deadtime part, this PR is ready for review.

@medha1996c
medha1996c marked this pull request as ready for review October 2, 2026 16:38
@medha1996c

Copy link
Copy Markdown
Contributor Author

Hi @alessandromontanari and @jlenain , the linearity and charge resolution are checked as well. So I have marked it as ready for review.

@jlenain jlenain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks a lot, @medha1996c , @alessandromontanari .
I think there are still a couple of comments to address.
Thanks !

@jlenain jlenain changed the title New PR for temperature dependent code Temperature dependent TRR tests Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants