Skip to content

chore: Update ibc-go dependency - #144

Merged
dianab-cl merged 9 commits into
mainfrom
ibc-rename-org
Nov 10, 2026
Merged

dianab-cl merged 9 commits into
mainfrom
ibc-rename-org

Conversation

@dianab-cl

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The PR changes the IBC dependency used across interchaintest’s chain and relayer workflows.

Fix the Docker build before merging; the shorter wallet names also bring back random setup failures.

Summary

Moves IBC imports to github.com/lfdt-ibc/ibc-go/v11 and pins a newer commit.

  • Interchaintest’s IBC code now uses the lfdt-ibc module.
  • Both modules and build paths now use Go 1.26.10.
  • Make now builds both modules and groups the end-to-end suites.

Reviews (4) · Last reviewed commit: "Update" · Reviewed by Greptile

@dianab-cl

Copy link
Copy Markdown
Contributor Author

@greptile review

@dianab-cl

Copy link
Copy Markdown
Contributor Author

@greptile review

Comment thread go.mod Resolved
Comment thread chain/cosmos/08-wasm-types/codec.go Resolved
@dianab-cl

Copy link
Copy Markdown
Contributor Author

@greptile review

1 similar comment
@dianab-cl

Copy link
Copy Markdown
Contributor Author

@greptile review

@greptile-apps

greptile-apps Bot commented Nov 10, 2026

Copy link
Copy Markdown

Comments Outside Diff

These findings could not be posted inline.

  • P1 Docker image cannot build Dockerfile.local-interchain:15 ▶

    COPY now requires go.work.sum, but that file is ignored and absent from a fresh checkout. Docker stops here, so make docker-build cannot produce an image.

    The later go mod tidy also runs before the root source is copied, even though local-interchain imports the root module through ../. Remove the missing input and copy both modules before running commands that need their source.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@dianab-cl

Copy link
Copy Markdown
Contributor Author

@

Comments Outside Diff

These findings could not be posted inline.

  • P1 Docker image cannot build Dockerfile.local-interchain:15 ▶
    COPY now requires go.work.sum, but that file is ignored and absent from a fresh checkout. Docker stops here, so make docker-build cannot produce an image.
    The later go mod tidy also runs before the root source is copied, even though local-interchain imports the root module through ../. Remove the missing input and copy both modules before running commands that need their source.
    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

but change is reverted

@dianab-cl
dianab-cl merged commit 88ccd80 into main Nov 10, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants