Skip to content

Wait for PR preview to serve the current revision - #15

Merged
makkes merged 3 commits into
mainfrom
improve-preview-workflow
Oct 30, 2026
Merged

makkes merged 3 commits into
mainfrom
improve-preview-workflow

Conversation

@makkes

@makkes makkes commented Oct 30, 2026

Copy link
Copy Markdown
Member

The preview workflow finished as soon as the manifest was pushed, before
Flux had rolled anything out. It now only succeeds once the preview is
reachable and serving the content of the PR's current commit.

The image writes the build revision to /version.txt (GIT_SHA build arg).
After pushing the manifest, the workflow polls the preview URL for up to
15 minutes until version.txt matches the commit being deployed and the
index page responds, and fails on timeout. This also catches stale
previews when a new commit is pushed to the PR branch. The PR comment is
posted only after this check passes.

github-actions Bot added a commit that referenced this pull request Oct 30, 2026
github-actions Bot added a commit that referenced this pull request Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🧹 Preview for this PR has been torn down.

@makkes
makkes force-pushed the improve-preview-workflow branch from 52ff210 to f234264 Compare October 30, 2026 11:43
github-actions Bot added a commit that referenced this pull request Oct 30, 2026
@makkes
makkes force-pushed the improve-preview-workflow branch from f234264 to ed19e04 Compare October 30, 2026 11:44
github-actions Bot added a commit that referenced this pull request Oct 30, 2026
The preview workflow finished as soon as the manifest was pushed, before
Flux had rolled anything out. It now only succeeds once the preview is
reachable and serving the content of the PR's current commit.

The image writes the build revision to /version.txt (GIT_SHA build arg).
After pushing the manifest, the workflow polls the preview URL for up to
15 minutes until version.txt matches the commit being deployed and the
index page responds, and fails on timeout. This also catches stale
previews when a new commit is pushed to the PR branch. The PR comment is
posted only after this check passes.
@makkes
makkes force-pushed the improve-preview-workflow branch from ed19e04 to 58b46e1 Compare October 30, 2026 11:47
github-actions Bot added a commit that referenced this pull request Oct 30, 2026
@github-actions

Copy link
Copy Markdown

🚀 Preview ready: https://pr-15.website-preview.coppersoft.dev

Verified: the preview is serving commit e8e5615.

Reference every action by the commit hash of a full semver release
(with the version in a comment) instead of a mutable major tag, so
workflow runs can't change underneath us.
github-actions Bot added a commit that referenced this pull request Oct 30, 2026
@github-actions

Copy link
Copy Markdown

🚀 Preview ready: https://pr-15.website-preview.coppersoft.dev

Verified: the preview is serving commit 9f0e71d.

github-actions Bot added a commit that referenced this pull request Oct 30, 2026
@github-actions

Copy link
Copy Markdown

🚀 Preview ready: https://pr-15.website-preview.coppersoft.dev

Verified: the preview is serving commit 309bda1.

Keep all actions used in .github/workflows up to date. Dependabot bumps
the pinned commit SHA and the version comment, including major releases.
All updates are combined into a single grouped PR, and only releases
that have been published for at least 7 days are proposed.
@makkes
makkes force-pushed the improve-preview-workflow branch from 781cbea to 14c8596 Compare October 30, 2026 11:56
github-actions Bot added a commit that referenced this pull request Oct 30, 2026
@github-actions

Copy link
Copy Markdown

🚀 Preview ready: https://pr-15.website-preview.coppersoft.dev

Verified: the preview is serving commit 38b4fac.

github-actions Bot added a commit that referenced this pull request Oct 30, 2026
@github-actions

Copy link
Copy Markdown

🚀 Preview ready: https://pr-15.website-preview.coppersoft.dev

Verified: the preview is serving commit 49088d3.

@makkes
makkes merged commit 77e137d into main Oct 30, 2026
2 checks passed
@makkes
makkes deleted the improve-preview-workflow branch October 30, 2026 12:00
github-actions Bot added a commit that referenced this pull request Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant