Repository navigation
Conversation
klihub
added this pull request to stack #848
October 20, 2026 05:17
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 20, 2026 07:55
bec4dde to
b28a5ef
Compare
klihub
removed this pull request from stack #848
October 20, 2026 08:38
klihub
added this pull request to stack #867
October 20, 2026 08:39
bart0sh
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 20, 2026 09:11
b28a5ef to
1726c23
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 20, 2026 11:26
1726c23 to
c66f997
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 20, 2026 19:04
c66f997 to
4663399
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 20, 2026 20:15
4663399 to
5d4791a
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 21, 2026 09:10
5d4791a to
5957820
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 21, 2026 11:39
5957820 to
42558de
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 21, 2026 15:02
42558de to
6563363
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved correctness issues affect claim preservation, identity, pending-pod scheduling, and resume cleanup.
4 open issues
1 file not reviewed
cmd/plugins/topology-aware/policy/e2eish-gen-n4c16_test.go: Generated file
What changed in this PR
Adds Dynamic Resource Allocation (DRA) support to e2e-ish replay and test generation for resource policies.
Changes:
- Models claim allocation, preparation, release, and pending pods.
- Preserves DRA objects and claim references in generated tests.
- Adds allocator tests and the topology-aware
test42-dra-devicesscenario.
| File | Description |
|---|---|
| pkg/testutils/e2eish/script.go | Adds DRA lifecycle and pending-pod handling. |
| pkg/testutils/e2eish/replay.go | Replays DRA object creation. |
| pkg/testutils/e2eish/pod.go | Adds pod and container claim options. |
| pkg/testutils/e2eish/harness.go | Supports claim preparation and CDI devices. |
| pkg/testutils/e2eish/generate.go | Generates DRA objects and claim options. |
| pkg/testutils/e2eish/dra.go | Implements replay-side claim allocation. |
| pkg/testutils/e2eish/dra_test.go | Tests allocation and object serialization. |
| pkg/resmgr/dra/names.go | Exposes CDI device naming. |
| pkg/resmgr/dra/names_test.go | Tests the shared naming helper. |
| pkg/resmgr/dra/cdi.go | Uses the shared naming helper. |
| go.sum | Adds dependency checksums. |
| go.mod | Adds allocator-related dependencies. |
| cmd/plugins/topology-aware/policy/e2eish-gen-n4c16_test.go | Adds the generated DRA device scenario. |
| cmd/plugins/topology-aware/policy/e2eish_test.go | Configures the policy's DRA driver. |
Review effort: Balanced
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: ns, | ||
| Name: pod.Name + "-" + pc.Name, | ||
| UID: types.UID(ns + "-" + pod.Name + "-" + pc.Name + "-claim"), |
| } | ||
| } | ||
|
|
||
| func (g *genTest) createPod(r *record) { |
Comment on lines
+379
to
+393
| // startPending starts the pods waiting for their claims to fit, in the order | ||
| // they were created, up to the first which still does not fit. A cluster's | ||
| // scheduler would go on past that one, but the order claims are allocated in | ||
| // is what the log of the e2e test recorded. | ||
| func (s *Script) startPending() { | ||
| s.t.Helper() | ||
|
|
||
| for len(s.pending) > 0 { | ||
| p := s.pending[0] | ||
| if !s.startPod(p.ns, p.pod) { | ||
| return | ||
| } | ||
| s.pending = s.pending[1:] | ||
| } | ||
| } |
| s.h.DeletePods(name) | ||
| // The kubelet unprepares the claims of a pod once its containers | ||
| // have stopped, and a claim of a template is the pod's own. | ||
| s.h.ReleaseClaims(s.dra.release(ns, name)...) |
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 21, 2026 17:12
6563363 to
6b1650c
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 21, 2026 19:31
6b1650c to
baaaf7f
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 22, 2026 07:14
baaaf7f to
8a4975e
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 22, 2026 07:32
8a4975e to
ab15b94
Compare
askervin
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 22, 2026 10:57
ab15b94 to
1519059
Compare
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 22, 2026 11:12
1519059 to
041ed12
Compare
Add e2e-ish support for stubbing enough of our DRA infra that we can replay e2e tests involving DRA. Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add unit tests for the e2e-ish DRA replay infrastructure itself. Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add the e2e-ish generated unit test corresponding to the topology- aware n4c16/test42-dra-devices e2e test. Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
stacked/klihub/e2eish/dra-replay
branch
from
October 22, 2026 12:13
041ed12 to
9ac3ee0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add e2d-ish support for recording and replaying e2e tests involving DRA. Add an e2e-ish generated DRA device unit test corresponding to the topology-aware n4c16/test42-dra-devices e2e test.
Stack created with GitHub Stacks CLI • Give Feedback 💬