Repository navigation
Path refactoring in ResolvePath, Dirname and FileTest - #122
Merged
Merged
Conversation
harendra-kumar
commented
Oct 23, 2026
harendra-kumar
commented
Member
- Rename doesItExist to pathExists.
- Move splitRoot from Dirname to a new internal Streamly.Coreutils.Path module, so that ResolvePath can share the UNC root fix.
- Replace filepath with streamly Path operations in ResolvePath. RequireParents now accepts missing/, as GNU realpath -E does.
- Make ResolvePath internal until streamly-core 0.4, which may provide path resolution on Path. Its doctests no longer run in CI.
ResolvePath needs the same UNC share root fix for streamly-core < 0.4.
Collapse .. with Path components, compare components with eqPathBytes, and check the parent with dirname. dirname ignores trailing separators, so RequireParents now accepts "missing/" like GNU realpath -E; takeDirectory gave "missing".
streamly-core 0.4 may provide path resolution on Path, wait for it before committing to this API. The test suite builds the module from src. cabal-docspec skips internal modules, so its doctests do not run.
cabal ignored CABAL_BUILDDIR in the environment, so the Windows build used dist-newstyle and hit the path length limit in hsc2hs.
harendra-kumar
force-pushed
the
refactor-changes
branch
from
October 23, 2026 21:09
45ef01c to
809565f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.