Repository navigation
Preserve whitespace in XML attributes - #644
Merged
Merged
Conversation
Use numeric character references for tabs and line endings in attributes so XML normalization preserves the AST values.
Contributor
|
LGTM. Maybe rename |
Contributor
Author
|
Renamed, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
[x](/ "a\nb")with a literal newline, the AST title isa\nb, but XML parsers read cmark's exported title asa b. CommonMark permits multiline titles, while XML 1.0 normalizes literal LF, TAB and CR in attributes to spaces.We emit numeric character references for these characters in XML attributes so the original values survive XML parsing.
We added an API regression test and ran the default and shared Release suites, plus independent checks with ElementTree and lxml.
— ChipLab