Repository navigation
Conversation
kathap
marked this pull request as draft
October 22, 2026 08:37
3 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove cc.staging_upload_user and cc.staging_upload_password from all capi-release job templates (cloud_controller_ng, cloud_controller_worker, cloud_controller_clock, cc_deployment_updater) and their job specs. The staging.auth block is no longer emitted in any generated config.
The staging.auth credential protected CC's local blobstore download endpoints (/staging/, /v2/buildpacks//download) so Diego cells could download packages, droplets and buildpacks directly from CC. This code path is only active when LocalClient is used, i.e. when blobstore_type: local or local-temp-storage is configured (LocalClient#local? returns true). The local blobstore only makes sense for single-instance local development; it cannot be shared across multiple CC instances in a real BOSH deployment. All supported BOSH deployments use storage-cli (e.g. DAV, Azure, S3), where StorageCliClient#local? returns false and the staging auth code path is never reached. Additionally, client_provider.rb explicitly rejects blobstore_type: webdav with an error.
The credential is therefore unreachable on any currently-supported BOSH blobstore configuration. Removing it from the job specs and templates eliminates a mandatory property with no effect, allowing operators to clean their deployment manifests. Local dev setups that still need staging.auth continue to work, the ccng config schema has been made optional in a companion change.
Links to any other associated PRs
Make staging.auth optional instead of mandatory cloud_controller_ng#5567
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite