Repository navigation
fix(release): drain v3.8.52 base-reds — #16956 fixtures, single customModels read in /api/models, stryker tap.testFiles - #17090
Merged
diegosouzapw merged 1 commit intoOct 18, 2026
Conversation
- tests: manual custom models now persist endpointCapabilitySource "operator" (#16956); the two deepEqual fixtures in managed-model-import and admin-audit-events learn the field (behavior intended by #16929). - /api/models: the #16929 operator endpoint overlay added a second bulk read of the customModels namespace per request. The capability snapshot now owns that single read (readCustomModelsByProvider + buildCustomModelVisionOverrides) and getAllActiveSyncedModels reuses the rows, so the api-models-hide-paid-6328 "bulk-read once" guard holds again without loosening it. New regression test covers the shared read. - stryker.conf.json: register the four covering tests the check:mutation-test-coverage gate reports (content-policy-refusal, stream-timing-late-output, chat-empty-stream-recovery, provider-error-rules-opt-in-flags-16797).
This was referenced Oct 18, 2026
Collaborator
Author
CI triage for this head (
|
| red check | failing test(s) | classification | evidence |
|---|---|---|---|
Docs Sync (Strict) |
[i18n-check] drifted sources (27) |
BASE-RED (docs) | identical on the base tip; the i18n wave PR covers it |
Unit Tests (3/8), Unit Tests fast-path (3/4) |
vision bridge key scope is translated without certifying stale locale content |
BASE-RED (i18n mirror test) | same failure in #17068's shards on the base; mirrors untouched here |
Unit Tests (4/8) |
resilience mirror provenance describes current source and target bytes, the two source-delta mirror records describe current source and translated bytes |
BASE-RED (i18n mirror tests) | fail on the untouched base tip locally (tests/unit/cli-env-quality-docs-mirrors.test.ts) |
Unit Tests (8/8) |
remote token privilege guidance is translated, not only marked current |
BASE-RED (i18n mirror test) | fails on the untouched base tip locally |
Unit Tests (1/8), Unit Tests fast-path (1/4) |
JON-562 real /v1/messages path rejects context-sized post-GC retention |
FLAKY / load-sensitive, not this PR | passes in #17068's shards (same base era, same runner image 20261012.601, same Node 24.21.0, 43–45 s) and fails here (38 s); fails locally on the pure base cda89ded and on a016744417 (101–138 s under load 26); this PR touches /api/models and the capability snapshot only — the /v1/messages path builds no snapshot and no module cache holds one (grep createModelCapabilityResolutionSnapshot open-sse/handlers src/app/api/v1/messages src/sse → none) |
The three tests this PR repairs (managed-model-import, admin-audit-events, api-models-hide-paid-6328) are green in every shard that ran them. Nothing above is introduced by this diff.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
Collaborator
Author
|
FYI for the i18n wave mentioned under "Not in this PR": #17117 already resyncs nine sources ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a016744417.Measured on the exact base
a016744417(2026-10-18)managed-model-import"sync keeps a same-id manual model as the user-configurable metadata override" andadmin-audit-events"deleting the final provider connection removes imported models but preserves manual models" — the stored manual row now carriesendpointCapabilitySource: "operator"addCustomModel) persists the field for manual models by design; the twodeepEqualfixtures were not updatedapi-models-hide-paid-6328"/api/models retains genuine resolved vision capability for the Video Bridge picker" —customModelsnamespace bulk-read 2× per request, the guard allows 1getAllActiveSyncedModelsreadcustomModelsfor the operator endpoint overlay, on top of the capability snapshot's vision readreadCustomModelsByProvider+buildCustomModelVisionOverrides) and exposes the rows;getAllActiveSyncedModels({ customModelsByProvider })reuses them. Guard holds at 1 without looseningcheck:mutation-test-coverage --strict: 4 covering unit tests missing fromstryker.conf.jsontap.testFilescontent-policy-refusal,stream-timing-late-output,chat-empty-stream-recovery,provider-error-rules-opt-in-flags-16797open-sse/mcp-server/__tests__/audit.test.ts > MCP audit shutdown > checkpointsbatch E2E: upload file, create batch, verify rate-limit logs appear(✖ at 250 s on CI)#13389 catalog 1350-model cold, warm and concurrent budgetstest:unit:cikilled at 4800 s with output still flowing (10.7 MB),test:integrationkilled at 2400 s,build:clikilled at 1200 s after a 19-minute Next compileomniroute-5(report artifacts of run 39100729020)Docs Sync (Strict)i18n drift + the four mirror testsdocs/i18n-wave-1018(in progress)Validation (worktree HEAD
2015887e74)a016744417and pass here —node --import tsx/esm --test tests/unit/managed-model-import.test.ts tests/unit/admin-audit-events.test.ts tests/unit/api-models-hide-paid-6328.test.ts→ 18/18.tests/unit/api-models-shared-custom-models-read.test.ts→ 4/4: snapshot reads the namespace once and exposes the rows; the listing performs 0 reads when handed those rows and still 1 standalone; the derived vision map equals the direct bulk read (malformed row skipped)./api/models) → 201/201.npm run typecheck:core→ exit 0 · eslint withconfig/quality/eslint-suppressions.jsonon the touched files → no new violation · prettier clean.npm run check:mutation-test-coverage→✓ No drift.Not in this PR