Repository navigation
fix(monitoring): warn once on unusable stall sampler reading - #15978
Merged
diegosouzapw merged 4 commits intoOct 18, 2026
Merged
diegosouzapw merged 4 commits into
diegosouzapw merged 4 commits into
Conversation
3 tasks
5 of 7 tasks
maxmad64bis
force-pushed
the
fix/event-loop-stall-sampler-nan-warn
branch
2 times, most recently
from
October 8, 2026 21:36
d5c6f0d to
7d997e9
Compare
maxmad64bis
marked this pull request as ready for review
October 8, 2026 22:02
maxmad64bis
marked this pull request as draft
October 9, 2026 08:58
maxmad64bis
marked this pull request as ready for review
October 9, 2026 09:28
maxmad64bis
marked this pull request as draft
October 9, 2026 09:51
maxmad64bis
marked this pull request as ready for review
October 9, 2026 10:11
maxmad64bis
marked this pull request as draft
October 9, 2026 17:03
maxmad64bis
force-pushed
the
fix/event-loop-stall-sampler-nan-warn
branch
from
October 9, 2026 18:11
7d997e9 to
754915d
Compare
maxmad64bis
marked this pull request as ready for review
October 9, 2026 18:12
7 tasks
Collaborator
|
Hi @maxmad64bis — closing this pull request to clear the open queue. The branch |
Collaborator
|
Hi @maxmad64bis — reopening this pull request. The close was a mistake, and it is back in the merge queue. The branch |
This was referenced Oct 11, 2026
Merged
Merged
Long freezes left no trace; a one-second timer now records each stall with its duration on recovery.
maxmad64bis
marked this pull request as draft
October 16, 2026 16:37
maxmad64bis
force-pushed
the
fix/event-loop-stall-sampler-nan-warn
branch
from
October 16, 2026 16:37
754915d to
52fcacb
Compare
NaN or negative readings fell back to 0 silently; each new case fails without the change.
maxmad64bis
force-pushed
the
fix/event-loop-stall-sampler-nan-warn
branch
from
October 16, 2026 16:48
52fcacb to
468449c
Compare
maxmad64bis
marked this pull request as ready for review
October 16, 2026 17:11
# Conflicts: # tests/unit/event-loop-stall.test.ts
…er-inference#15888 landed cheaper-inference#15888 was squash-merged while this branch still carried its commits, so the merge of the release branch appended a second copy of the stall recorder functions. Restore the release version of the file and re-apply only this PR's own change (the one-time warning on an unusable sampler reading).
diegosouzapw
merged commit Oct 18, 2026
279bbec
into
cheaper-inference:release/v3.8.52
8 checks passed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stall log lines showed
inflight=0with no warning when the sampler returned an unusable reading, hiding it among real zeros. When the sampler returnsNaNor a negative value, the fallback keeps zero but stays silent, while a throwing sampler warns once. Now an unusable reading falls back to zero with the same one-time warning, so a zero from a broken sampler is marked as such.Related Issues
Target Branch
release/v3.8.xbranch (the highest openrelease/v*), notmainv4-featurelabel for the v4 channelValidation
npm run lintTests Added Or Updated
tests/unit/event-loop-stall.test.ts— new cases forNaN, negative and unbounded sampler readings (each falls back to zero with a single warning) and a healthy reading (count kept, no warning).Coverage Notes
src/lib/healthzLag.ts— covered bytests/unit/event-loop-stall.test.ts.Reviewer Notes
inflight=0from an unusable sampler reading now carry the existing one-time warning; healthy readings are unchanged.