Skip to content

Fix weighted Kabsch lint failure blocking Testing (3.10) - #136

Closed
charnley with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-testing-3-10-job
Closed

charnley with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-testing-3-10-job

Conversation

Copilot AI commented Sep 26, 2026 •

Copy link
Copy Markdown

The failing Testing (3.10) GitHub Actions job was caused by a Ruff SIM108 violation in the weighted Kabsch path, not a Python 3.10 compatibility issue. This updates that code path to satisfy CI linting while preserving behavior.

  • CI failure root cause

    • Replace the if/else assignment for default weights in kabsch_weighted with the equivalent inline expression Ruff expects.
  • Behavior guard

    • Add a focused regression test covering the W=None path against explicit uniform weights to keep the default weighted behavior pinned.
  • Illustrative change

    W = np.ones(len(P)) / len(P) if W is None else W

Co-authored-by: charnley <2011468+charnley@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Testing (3.10) Fix weighted Kabsch lint failure blocking Testing (3.10) Sep 26, 2026
Copilot AI requested a review from charnley September 26, 2026 17:26
@charnley charnley closed this Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants