Repository navigation
chore: upgrade playground to Expo SDK 58 - #570
Open
lukewalczak wants to merge 1 commit into
Open
lukewalczak wants to merge 1 commit into
lukewalczak wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the playground to Expo SDK 58 (React Native 0.88, React 19.3) and moves the workspace catalog to the same versions.
react-native-performanceto 7.0.0 in the playground and@rozenite/performance-monitor-plugin.rozenite buildfor plugins on React Native 0.87+: the CommonJS emit no longer type checks (noCheck).NativeEventEmitterin the network activity WebSocket interceptor and fix two playground type errors surfaced by the new React Native types.Related Issue
Closes
Context
Since React Native 0.87,
react-native/package.jsonhas no top-leveltypesfield; types are published only throughexports. The CommonJS emit ofrozenite buildusesmoduleResolution: node10, which ignoresexports, so every plugin whose React Native entry importsreact-nativefailed withTS7016(5 of 14 plugins in this repo). The emit without declarations now setsnoCheck: the declaration emit of the same target still type checks the same sources withbundlerresolution, and the compiled CommonJS output of all 14 plugins is byte-for-byte identical with and without it.noCheckneeds TypeScript 5.6+; the plugin template has shipped 5.7+ since its first commit.react-native-performance5.1.4 does not compile on iOS against React Native 0.88 (StartupLoggerlostgetRunJSBundleEndTimeand friends); 7.0.0 keeps the same public API. Nitro packages stay on the versions frommain; they were verified on both platforms.expo-doctorstill reports duplicateexpocopies, which already exist onmain(peer variants differing only bytypescriptversion).Testing
Automated:
pnpm checks:affected— 106/106 taskspnpm test:affected— 72/72 taskspnpm --filter @rozenite/playground exec expo install --check— dependencies up to datepnpm install --frozen-lockfileManual, playground on Android emulator (Pixel 8 Pro) and iOS simulator (iPhone 17 Pro, iOS 27.1):
pnpm --filter @rozenite/playground android/iosbuild, install and start without crashes.