Repository navigation
fix(plugin-brownfield-ios): keep relative symlinks when copying XCFrameworks - #741
Open
cusnirvladislav wants to merge 1 commit into
Open
cusnirvladislav wants to merge 1 commit into
cusnirvladislav wants to merge 1 commit into
Conversation
…meworks fs.cpSync rewrites relative symlinks into absolute paths unless verbatimSymlinks is set. Versioned framework slices, such as the Mac Catalyst slice of hermesvm.xcframework, then point into the packaging machine's Pods folder, and SwiftPM refuses to extract a binary target whose symlinks resolve outside the archive. Fixes callstackincubator#740 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@cusnirvladislav is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #740
Summary
Adds
verbatimSymlinks: trueto thecpSynccalls that copy frameworks duringpackage:ios:copyHermesXcframework, both copies incopyReactXcframeworks, andcopyDirectoryinmergeFrameworks. With it, relative symlinks in versioned framework slices stay relative instead of pointing into the packaging machine'sPodsfolder, so SwiftPM can extract the published binary targets.Test plan
copyHermesXcframework.test.tscopies a versioned framework with relative links and checks them afterwards. Without the change the link comes back as an absolute path and the test fails.vitest run packages/plugin-brownfield-ios packages/platform-apple-helperspasses (38 tests).hermesvm.framework/Resourcesin the published zip points toVersions/Current/Resources.