Repository navigation
feat: structural accessibility for data table #5082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oleksandrzavarzin-callstack
wants to merge
14
commits into
callstack:main
Choose a base branch
from
oleksandrzavarzin-callstack:feat/structural-accessibility-for-DataTable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,496
−3,292
Open
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e7390ef
refactor(data-table): add accessibility and column primitives
oleksandrzavarzin-callstack 40fd57b
feat(button): expose aria-expanded
oleksandrzavarzin-callstack 5e94593
feat(data-table): expose table structure to assistive technology
oleksandrzavarzin-callstack 5909225
fix(data-table): give pagination controls real accessible names
oleksandrzavarzin-callstack 71f79a7
doc(data-table): update migration docs
oleksandrzavarzin-callstack a91122e
fix(data-table): adress the pr comments
oleksandrzavarzin-callstack 33d651f
fix(data-table): count only real rows and survive fragment children
oleksandrzavarzin-callstack 59302c0
fix(data-table): tell a row component from a wrapper by its type
oleksandrzavarzin-callstack 6d3780c
Merge remote-tracking branch 'upstream/main' into feat/structural-acc…
oleksandrzavarzin-callstack 20bc409
fix(data-table): keep pressable-only props out of the emitted types
oleksandrzavarzin-callstack 607a423
fix(data-table): leave wrapper as written instead of cloning
oleksandrzavarzin-callstack e53c7ba
Merge remote-tracking branch 'upstream/main' into feat/structural-acc…
oleksandrzavarzin-callstack c7eebe8
fix(data-table): omit a divider between rows from counting as a row
oleksandrzavarzin-callstack 3c0d158
Merge remote-tracking branch 'upstream/main' into feat/structural-acc…
oleksandrzavarzin-callstack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example puts
DataTable.TitleandDataTable.Celldirectly inDataTable. With this PR the title is then counted as a row. A complete structure shows the change better:(via Claude, verify if it makes sense)