Skip to content

fix(ios): render pager pages inside FullWindowOverlay #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
troZee merged 1 commit into from
Oct 29, 2026
+13 −13
Merged

fix(ios): render pager pages inside FullWindowOverlay #1204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions ios/PagerViewProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,26 +74,26 @@ final class PagerViewProvider: UIView, RNCPagerViewProviding {
super.didMoveToWindow()
if window != nil {
setupView()
} else {
syncParentViewController(to: nil)
}
}

override func willMove(toWindow newWindow: UIWindow?) {
super.willMove(toWindow: newWindow)
if newWindow != nil {
syncParentViewController()
syncParentViewController(to: reactViewController())
}
}

override func willMove(toSuperview newSuperview: UIView?) {
if let parentViewController = newSuperview?.reactViewController() {
syncParentViewController(to: parentViewController)
}
syncParentViewController(to: newSuperview?.reactViewController())
super.willMove(toSuperview: newSuperview)
}

override func didMoveToSuperview() {
super.didMoveToSuperview()
syncParentViewController()
syncParentViewController(to: reactViewController())
}

override func layoutSubviews() {
Expand Down Expand Up @@ -208,13 +208,14 @@ final class PagerViewProvider: UIView, RNCPagerViewProviding {

private func setupView() {
if self.hostingController != nil {
syncParentViewController()
syncParentViewController(to: reactViewController())
return
}

guard let parentViewController = reactViewController() else {
return
}
// Window-level containers, such as FullWindowOverlay, do not have a
// controller in their responder chain. The hosting view can still render
// there, but must not be attached to an unrelated controller.
let parentViewController = reactViewController()

// The hosting view must not carry a safe area: `PagerView`'s `GeometryReader`
// is measured inside it, and every page is framed to that measurement, so the
Expand All @@ -230,7 +231,7 @@ final class PagerViewProvider: UIView, RNCPagerViewProviding {
)
self.hostingController = hostingController

parentViewController.addChild(hostingController)
parentViewController?.addChild(hostingController)
hostingController.view.backgroundColor = .clear
addSubview(hostingController.view)

Expand All @@ -243,16 +244,15 @@ final class PagerViewProvider: UIView, RNCPagerViewProviding {
/// SwiftUI can recreate the page controller around this React view while
/// preserving the view itself. Keep the hosting controller attached to the
/// current page controller so UIKit's view-controller hierarchy stays valid.
private func syncParentViewController(to parentViewController: UIViewController? = nil) {
private func syncParentViewController(to parentViewController: UIViewController?) {
guard let hostingController,
let parentViewController = parentViewController ?? reactViewController(),
hostingController.parent !== parentViewController else {
return
}

hostingController.willMove(toParent: nil)
hostingController.removeFromParent()
parentViewController.addChild(hostingController)
parentViewController?.addChild(hostingController)
hostingController.didMove(toParent: parentViewController)
}
}
Loading