Repository navigation
test: cover interactive singleton manual ID selection - #7109
Merged
Merged
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7109 +/- ##
==========================================
+ Coverage 79.26% 80.49% +1.23%
==========================================
Files 149 149
Lines 21216 21243 +27
Branches 3276 3281 +5
==========================================
+ Hits 16817 17100 +283
+ Misses 3585 3314 -271
- Partials 814 829 +15 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression coverage for interactive singleton imports where the user manually enters a MusicBrainz recording ID.
PR #7005 fixed an issue where manually selected metadata candidates were not correctly applied during interactive imports. Its tests cover album manual ID selection and singleton manual search, but not singleton manual ID selection.
This test fills that remaining coverage gap.
Changes
test_singleton_manual_id_updates_candidatestoImportSingletonTest.No production code changes.
Verification
The 2.14.0 failure occurs after the recording ID lookup succeeds, confirming that the test exercises the original regression.
Additional checks:
git diff --check: passedAI assistance disclosure
ChatGPT assisted with investigating the regression, identifying the missing test scenario, drafting the test and reviewing the results.
I personally reviewed and applied the changes, executed the tests against both Beets versions, verified the results and created the commit. I will handle the pull request and any maintainer feedback myself.