Repository navigation
Pin Ruby 3.4.9 and use Bundler 4.0.22 and Xcode 26.6 - #83
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The version pins are valid, internally consistent, and verified against the macOS signing workflow.
Review effort: Balanced
Findings: None
What changed in this PR
Pins Ruby, Bundler, and Xcode versions for reproducible macOS signing CI.
Changes:
- Pins Ruby 3.4.9 and Bundler 4.0.22.
- Updates CI to Xcode 26.6.
- Removes obsolete Bundler configuration and Nokogiri note.
| File | Description |
|---|---|
.ruby-version |
Pins Ruby 3.4.9. |
.xcode-version |
Selects Xcode 26.6. |
.bundle/config |
Removes obsolete platform configuration. |
Gemfile.lock |
Records Bundler 4.0.22. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
iangmaia
enabled auto-merge
October 2, 2026 17:18
AliSoftware
approved these changes
Oct 2, 2026
Comment on lines
-1
to
-3
| # Pinned: nokogiri 1.19.3 won't compile from source on the Xcode 26.5 image | ||
| # (its clang breaks the bundled gumbo build). 26.3 builds it. Bump once a newer | ||
| # image compiles nokogiri from source (we force the Ruby platform via .bundle/config). |
There was a problem hiding this comment.
I guess a green CI build confirms that this is no longer an issue with Xcode 26.6?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
.ruby-versionpinned to 3.4.9, so the Fastlane signing tooling no longer depends on the CI image's default Ruby. Also bumps Bundler 2.5.11 → 4.0.22.Fixes https://linear.app/a8c/issue/AINFRA-2869
Testing
bundle install(nokogiri compiles from source withBUNDLE_FORCE_RUBY_PLATFORM), andbundle exec fastlane lanesloads the Fastfile without Ruby deprecation warnings.🤖 Generated with Claude Code