Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1404 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of Changes
Constructor-style calls such as
ArrowFactory().get(2024, 6, 1)andarrow.get(year=2024, month=6, day=1)work at runtime but fail type checking because the corresponding overloads are missing. Add a constructor overload to each public entry point, covering positional and keyword date fields, optional time fields, timezone and fold. Existing overloads and runtime behavior are unchanged.Add static regression checks to the existing mypy hook. Eleven supported calls fail before the change and pass after it; incomplete dates and string day values remain rejected. The fixture is explicitly enabled in the mypy configuration because other test modules skip type errors.
Validation on Windows with Python 3.12:
No documentation update is needed: these constructor forms are already supported and documented. This change was developed with OpenAI Codex.