Repository navigation
test: cover zero limit in Arrow.range - #1394
Open
renanmpimentel wants to merge 1 commit into
Open
renanmpimentel wants to merge 1 commit into
renanmpimentel wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1394 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
pytest: 1,905 tests).master(not verified after submission).Description of Changes
Treating
limit=0as an omitted limit would yield dates instead of an empty iterator. The new test protects bothArrow.rangeforms, including the explicit-end branch that old tests missed.Supertest audit method
I used the Supertest test-audit skill to probe whether the existing suite would catch a plausible violation of this contract. The regression was applied only in an isolated worktree. The regression proof records three executed states: the existing tests pass with that regression, the new assertion fails against the same regression, and the new test passes with the original production code restored. The published diff adds tests only.
Adds regression coverage for
Arrow.range(..., limit=0)with and without an explicit end. A maximum result count of zero should produce an empty iterator in both forms.Proof: treating a falsy limit as omitted in the explicit-end branch leaves all 1,904 existing tests passing, but the new test fails because it produces three dates. With production code restored, 1,905 tests pass at 99.93% coverage. Black, isort, flake8, mypy, compileall, and
git diff --checkpass.This PR changes tests only.
Repository guidance and CI
The repository PR checklist is included above. Local pytest, Black, isort, flake8 and mypy passed. Three CI jobs currently fail before executing this test during interpreter or dependency setup; they are not marked as passed.