Skip to content

fix(safari): list every language on the App Store - #1249

Merged
ankit merged 1 commit into
mainfrom
claude/safari-app-store-language-9fae55
Oct 30, 2026
Merged

ankit merged 1 commit into
mainfrom
claude/safari-app-store-language-9fae55

Conversation

@ankit

@ankit ankit commented Oct 30, 2026

Copy link
Copy Markdown
Owner

The Mac App Store shows only English for Stylebot because it takes its language list from the `.lproj` folders in the app bundle, and the app only had `Base.lproj`. The app window was already translated at runtime from the extension's `_locales`, but the store doesn't look there.

  • New "Add localizations" build step on the app target writes `.lproj/InfoPlist.strings` for each locale in `safari-dist/_locales`, using Apple's names (`pt_BR` → `pt-BR`, `zh_CN` → `zh-Hans`, `zh_TW` → `zh-Hant`), so new locales are picked up automatically.
  • Turns off user script sandboxing on the app target so the step can read `safari-dist`, as the extension target already does.

Review notes: The App Store picks this up only from the next uploaded build.

Testing: After `yarn build:safari`, an unsigned Release `xcodebuild` succeeds and `Stylebot.app` contains 17 `.lproj` folders.

🤖 Generated with Claude Code

…App Store lists every language

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Bundle size

No change to what the popup or content scripts load.

Bundle Size Change Gzip Change
Popup 231.2 KB – 59.1 KB –
fonts/fonts.css 2.9 KB – 458 B –
popup/index.css 33.5 KB – 6.8 KB –
popup/index.js 194.8 KB – 51.8 KB –
Content script (document_start) 112.2 KB – 27.2 KB –
editor/index.js 59.7 KB – 13.6 KB –
inject-css/index.js 45.1 KB – 11.7 KB –
site-bridge/index.js 7.5 KB – 1.9 KB –

@ankit
ankit merged commit 696650c into main Oct 30, 2026
7 checks passed
@ankit
ankit deleted the claude/safari-app-store-language-9fae55 branch October 30, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant