Repository navigation
fix(safari): list every language on the App Store - #1249
Merged
Merged
Conversation
…App Store lists every language Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bundle sizeNo change to what the popup or content scripts load.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mac App Store shows only English for Stylebot because it takes its language list from the `.lproj` folders in the app bundle, and the app only had `Base.lproj`. The app window was already translated at runtime from the extension's `_locales`, but the store doesn't look there.
Review notes: The App Store picks this up only from the next uploaded build.
Testing: After `yarn build:safari`, an unsigned Release `xcodebuild` succeeds and `Stylebot.app` contains 17 `.lproj` folders.
🤖 Generated with Claude Code