Skip to content

Type Hinting #58

Closed
Closed

Description

@AndKaminer

This goes well with #54, but since technically type hinting isn't part of PEP 8, I pulled it out here. Is type hinting something we want to do? We can check it with something like mypy, which can be automated just like unit testing and flake8. Thoughts?

Activity

  1. MarcCote commented on Dec 18, 2023

    @MarcCote
    Collaborator

    Type hinting is always great. I like the idea of running mypy but I wouldn't make it as a mandatory check for now.

  2. pangwangshu commented on Aug 5, 2026

    @pangwangshu
    Contributor

    Opened #89 to complete this — extends the type hints already started on ScienceWorldEnv's snake_case API to the remaining untyped surface (utils.py, the deprecated camelCase wrapper methods, BufferedHistorySaver, etc.), plus two small bugfixes mypy caught along the way.

    Per @MarcCote's comment, added mypy as an opt-in tox env (tox -e mypy) rather than a mandatory CI check for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions