You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This goes well with #54, but since technically type hinting isn't part of PEP 8, I pulled it out here. Is type hinting something we want to do? We can check it with something like mypy, which can be automated just like unit testing and flake8. Thoughts?
Opened #89 to complete this — extends the type hints already started on ScienceWorldEnv's snake_case API to the remaining untyped surface (utils.py, the deprecated camelCase wrapper methods, BufferedHistorySaver, etc.), plus two small bugfixes mypy caught along the way.
Per @MarcCote's comment, added mypy as an opt-in tox env (tox -e mypy) rather than a mandatory CI check for now.
Activity
MarcCote commentedon Dec 18, 2023
Type hinting is always great. I like the idea of running mypy but I wouldn't make it as a mandatory check for now.
pangwangshu commentedon Aug 5, 2026
Opened #89 to complete this — extends the type hints already started on
ScienceWorldEnv's snake_case API to the remaining untyped surface (utils.py, the deprecated camelCase wrapper methods,BufferedHistorySaver, etc.), plus two small bugfixes mypy caught along the way.Per @MarcCote's comment, added mypy as an opt-in tox env (
tox -e mypy) rather than a mandatory CI check for now.Complete type hinting and add opt-in mypy tox env (#58)