Repository navigation
benchmarking: add the nighthawk-egress test type - #3841
Open
Yuan Gao (ygao-g) wants to merge 3 commits into
Open
Yuan Gao (ygao-g) wants to merge 3 commits into
Yuan Gao (ygao-g) wants to merge 3 commits into
Conversation
Add USES_SHARED_WORKLOADS and teardown_workloads to TestType. The orchestrator deploys benchmarking/workloads only for types that use it and calls teardown_workloads before and after each test. Signed-off-by: Yuan Gao <ypgao@google.com>
The invoker Envoy runs on 127.0.0.1 as a sidecar of the runner Job in nighthawk-egress-runner-job.yaml.tmpl. The Job runs as benchmarking/benchmark-runner. Manual runs in the README forward a port with kubectl-ate proxy actor. Signed-off-by: Yuan Gao <ypgao@google.com>
nighthawk-egress pins deployment/atenet-egress to one replica and envoyCpu cores, deploys and tears down its own Nighthawk rig, and runs the runner Job from nighthawk-egress-runner-job.yaml.tmpl. Signed-off-by: Yuan Gao <ypgao@google.com>
Yuan Gao (ygao-g)
assigned
Chuang Wang (chuangw6) and unassigned
Chuang Wang (chuangw6)
Yuan Gao (ygao-g)
assigned
Bowei Du (bowei) and unassigned
Bowei Du (bowei) and
Yuan Gao (ygao-g)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new
nighthawk-egresstest type, the orchestrator pinsdeployment/atenet-egressto one replica andenvoyCpucores, deploys the Nighthawk rig, and submits the runner Job. Test types can now skip deployingbenchmarking/workloadsand tear down their own workloads.nighthawk-egresssupports only thegvisorsandbox class.The invoker Envoy that adds the
ate-target-actorheader moves from a Deployment to a sidecar of the runner Job that listens on127.0.0.1. The sidecar connects toatenet-routerasbenchmarking/benchmark-runner, which the orchestrator already allows. Manual runs in the README forward a port withkubectl-ate proxy actorand requireate-system/atenet-clienton the ingress allow list.A run of the type needs the runner image from the runner PR and the
kubectl-atebuild from #3627.Part of #3624
AI use: AI-assisted for the diff, the split and the test runs; I reviewed the diff.