Repository navigation
benchmarking only: move the shared Nighthawk adaptive-load helpers into nighthawk_common - #3628
Merged
Lior Lieberman (LiorLieberman) merged 3 commits intoNov 13, 2026
Conversation
Closed
2 tasks done
Yuan Gao (ygao-g)
requested review from
Bowei Du (bowei) and
Chuang Wang (chuangw6)
November 4, 2026 19:06
Chuang Wang (chuangw6)
approved these changes
Nov 5, 2026
Yuan Gao (ygao-g)
force-pushed
the
nighthawk-common-extract
branch
from
November 5, 2026 19:07
8cd46d5 to
cfcbd56
Compare
2 tasks done
…f nighthawk-ingress Move nighthawk-ingress/output.py to nighthawk_common unchanged so nighthawk-egress can reuse it. The ingress Dockerfile copies the package into the image and the ingress tests put benchmarking/ on sys.path. Signed-off-by: Yuan Gao <ypgao@google.com>
… out of nighthawk-ingress Move nighthawk-ingress/spec.py to nighthawk_common unchanged and point its importers at the new path. actors.py imported it without using it. Signed-off-by: Yuan Gao <ypgao@google.com>
…ut of nighthawk_common build_session_spec in nighthawk_common now takes a finished traffic template. The router SNI, the certificate paths and build_spec_dict, which assembles that template, move back to nighthawk-ingress/spec.py. Signed-off-by: Yuan Gao <ypgao@google.com>
Yuan Gao (ygao-g)
force-pushed
the
nighthawk-common-extract
branch
from
November 5, 2026 22:53
cfcbd56 to
5d125f1
Compare
Bowei Du (bowei)
approved these changes
Nov 6, 2026
This was referenced Nov 6, 2026
Yuan Gao (ygao-g)
changed the title
Collaborator
|
This is a benchmarking only pr that has been already approved. Fine to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3624 (Stage 1, item 2): share the adaptive load session spec and output helpers between
nighthawk-ingressand the comingnighthawk-egressrunner.What changes
Pure relocation, no behavior change.
nighthawk-ingress/output.pyandspec.pymove tobenchmarking/nighthawk_common/. The router-specific parts of the spec builder (router SNI, certificate paths,build_spec_dict) stay innighthawk-ingress/spec.py, which now calls the genericbuild_session_spec. Callers and tests importnighthawk_commondirectly; the ingress Dockerfile copies the package into the image.Review guide
output.pyrename (GitHub shows 100%), two import lines, the DockerfileCOPY, twosys.pathlines in the ingress tests.spec.pyrename at 100%, importers repointed, an unused import dropped fromactors.py.nighthawk_common/spec.pyas deletions andnighthawk-ingress/spec.pyas the same lines moving back.Testing
hack/verify/benchmarking-python.sh: the ingress suite passes at each commit, and fails without the newsys.pathlines, so the import path is exercised.Independent of #3627. #3629 and #3630 stack on both.
AI use: AI-assisted for the diff, the commit split and the test runs; I reviewed the diff.