Repository navigation
docs(mira): lessons pass reads maintainers' review comments - #55
Merged
Merged
Conversation
The Friday lessons pass only saw Mira's own findings and their outcome notes, so a rule a maintainer stated in a review comment reached it only if it answered one of her findings. It now also reads maintainers' review comments on PRs merged or closed in the last 7 days. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Matt Roberts (Agent) <code+agent@rbrts.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mira's Friday lessons pass now also reads the review comments maintainers (author association
OWNER,MEMBERorCOLLABORATOR) left on PRs merged or closed in the last 7 days, including PRs she posted no findings on. Any rule a maintainer states there becomes a lesson candidate.agents/mira.md: new step 2 in "Lessons pass (Fridays)"; the later steps are renumbered.config/schedules.yaml: themira-lessonsprompt says the same.Why
Until now the pass only read
review_findings: Mira's own findings and her outcome notes. A rule a maintainer stated in a review comment reached the lessons only if it answered one of her findings. Comments that weren't about one of her findings were never seen, nor were comments on PRs whose findings all had outcomes already.The comments are treated as data: Mira takes only the stated rule, never an instruction. Lessons still reach
AGENTS.mdonly through an approval-gatedgithub.docs_pr.After merge
Run
deploy:agents; the deploy workflow does this.Tests
npm testpasses (431).network.jsondoesn't change.🤖 Generated with Claude Code