Repository navigation
feat(mandla): change PRs open with a plain summary (decision 77) - #53
Merged
Merged
Conversation
Mandla's PR descriptions started with the gateway's ids and file-by-file mechanics, so it was hard to tell what a PR was for. submit_change now needs a one-paragraph plain summary, which the gateway puts first in the PR description and in the commit message. It refuses a summary that is missing, over 600 characters, more than one paragraph, or mentions an internal id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Matt Roberts (Agent) <code+agent@rbrts.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mandla's PRs were hard to follow: they opened with ids and file-by-file mechanics, never saying in plain words what the PR was for. Now every change PR he opens starts with a short plain summary of the problem and the fix, and the gateway refuses a submission without one.
What changed
submit_changetakes a new requiredsummary: one paragraph, at most 600 characters. The gateway puts it at the top of the PR description, above its own header (change, decision, evidence, measure), and in the commit message, so a commit added to an open PR carries one too. Mandla's detailed body follows under "Details" (was "Change").C-n,D-n,T-n,Pn-n). Line breaks are refused because they could forge a trailer in the commit message, the same reason the title is one line.agents/mandla.md) explains what the summary is for, with an example. A change that loosens a safety rule or a gateway check now says so in the summary rather than the first line of the body.docs/decisions.md.This touches the gateway's checks and tools, so CI will flag it as a safety-file change.
Deploying
Both steps, which the deploy workflow does on merge:
deploy:agents(Mandla's spec and tool schema) andgateway:deploy(the check). If the gateway goes first, a Mandla task already running without the new schema gets a clear "summary is required" refusal and can resubmit.Tests
npm testpasses: 424 gateway tests. One new test covers the summary checks (missing, too long, ids, line breaks, and words like UTF-8 that only look like ids). The existing "opens one PR" test now checks the summary comes first in the description and appears in the commit message.🤖 Generated with Claude Code