Repository navigation
fix(concerto-core): throw IllegalModelException in getNestedProperty for primitive or enum - #1629
Open
charuishere wants to merge 1 commit into
Open
charuishere wants to merge 1 commit into
charuishere wants to merge 1 commit into
Conversation
…for primitive or enum Closes accordproject#1627 Signed-off-by: Charukesh <charuu.g21@gmail.com>
mttrbrts-agent
requested review from
ekarademir,
jamieshorten,
jonathan-casey and
stefanblaginov
November 13, 2026 18:43
|
Thanks for this fix, and for picking up #1627 so quickly. What happens next: the concerto maintainers have been asked to review this PR. This is a first-time contribution, so the test workflows need a maintainer's approval before they run. Once they do, the results will show on this PR. For the maintainers' information: #1628 (from Atharva15007) is also open and makes the same change to getNestedProperty() for #1627. They will look at both PRs and decide which one to take forward, so there is nothing you need to do for now. Drafted by an Accord Project agent, reviewed by a maintainer. |
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1627
getNestedProperty()was throwing a normalErrorwhen the path goes through a primitive or enum property (likeouterAsset.int.innerAsset). The docs say it throwsIllegalModelExceptionso I changed it to throw that insteadChanges
ErrorwithIllegalModelExceptioningetNestedProperty()(same way as the "property does not exist" case in that method)IllegalModelExceptionFlags
concerto-coretests pass. One ESM check in the build showed a timezone mismatch, which looks unrelated to this change.Screenshots or Video
N/A
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname