Repository navigation
Conversation
WerWolv
requested changes
Aug 16, 2026
| } | ||
|
|
||
| static void drawProviderContextMenu(prv::Provider *provider) { | ||
| if (auto *memoryProvider = dynamic_cast<prv::MemoryProvider*>(provider); memoryProvider != nullptr) { |
Owner
There was a problem hiding this comment.
Instead of hardcoding the menu items here, use the existing IProviderMenuItems facility
tianrking
force-pushed
the
codex/rename-memory-provider
branch
from
October 15, 2026 07:12
15e72c0 to
bcbc5fd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2669
Allow renaming in-memory tabs opened from pattern sections and virtual files. Use a builtin PatternDataProvider that implements IProviderMenuItems, so the existing provider menu handles the rename action. Update the window title after renaming.
Rebased onto current master and preserved the current pattern type naming behavior.
Validation: git diff --check passed. A local build remains unverified: this Windows environment has CMake 3.21.3, below the required 3.25, and lacks the build dependencies.