Repository navigation
Conversation
🦋 Changeset detectedLatest commit: dd54ddb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The toolkit replacement change is mergeable after normal checks; no outstanding issue is identified. Pre-merge checks |
|
Replacing a toolkit with the same toolkit name and tool names returns
false, leaving the old schema and implementation in use.addToolkit()checks the incoming names against the toolkit it is supposed to replace, even though its documented behavior permits replacement.Check standalone user/provider tools and other toolkits for conflicts, excluding only the toolkit being replaced. Validate before mutating the registry so a rejected replacement preserves the existing toolkit. Include a patch changeset for
@voltagent/core.Validation:
tsc --noEmit, a separate strict type check including the changed spec, and Biome checks for both changed TypeScript files pass.Tests use Node 22.18.0, Vitest 3.2.4 and isolated dependencies with the affected AI SDK versions taken from the upstream lockfile. Vitest uses
--configLoader runnerto avoid a Windows config-bundling access error. The full monorepo build/test suite was not run.AI assistance was used for the implementation and tests; the final change and conflict boundaries were reviewed and the real repository tests rerun.
Summary by cubic
Fixes
addToolkit()so replacing a toolkit with the same name and tool names succeeds instead of returningfalseand leaving the old schema and implementation in use.Conflict checks now exclude only the toolkit being replaced, while still rejecting collisions with standalone user/provider tools and other toolkits. Validation runs before the registry is mutated, so a rejected replacement preserves the existing toolkit. Five regression tests cover user and provider tool replacement plus conflict cases, and a patch changeset is added for
@voltagent/core.Written for commit dd54ddb. Summary will update on new commits.
Summary by CodeRabbit