Skip to content

Fix random GitHub avatar on locally imported plugin rows #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragonx943 merged 1 commit into from
Sep 27, 2026
Merged

Fix random GitHub avatar on locally imported plugin rows #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/kotlin/org/draken/usagi/core/image/CoilImageView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ open class CoilImageView
}
networkWaitingJob?.cancel()
networkWaitingJob = null
// a recycled view may still be waiting on the previous holder's request
previous?.dispose()
currentImageData = request.data
return coil.enqueue(request).also { currentRequest = it }
}
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/kotlin/org/draken/usagi/settings/sources/manage/plugins/PluginManageAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ class PluginManageAdapter(
binding.imageViewIcon.errorDrawable = fb
binding.imageViewIcon.fallbackDrawable = fb
if (avatar.isNullOrBlank()) {
binding.imageViewIcon.disposeImage()
binding.imageViewIcon.setImageResource(R.drawable.ic_services)
} else {
applyIconShape(binding.imageViewIcon, context)
Expand Down Expand Up @@ -122,6 +123,7 @@ class PluginManageAdapter(
binding.imageViewIcon.fallbackDrawable = fb
val icon = if (item.isLocal) item.installed.firstOrNull()?.iconUrl else githubAvatarUrl(item.repositoryLabel)
if (icon.isNullOrBlank()) {
binding.imageViewIcon.disposeImage()
binding.imageViewIcon.setImageDrawable(fb)
} else {
binding.imageViewIcon.setImageAsync(icon)
Expand Down
Loading