Repository navigation
build(release): make the DMG with diskutil image instead of hdiutil - #3524
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#3512 builds the DMG with
hdiutil create -srcfolder. macOS 27 deprecates hdiutil, and Release Build run 39117792525 on the xcode-27 runner logs'hdiutil create -volname -format ...' is deprecated. Please use 'diskutil image create from/blank --volumeName --format ...' instead.man hdiutil(macOS 27.0.1) mapscreate -srcfoldertodiskutil image create from.Change
package.sh:diskutil image create from "$WORK/dmg" "$dmg" --volumeName "TablePro $VERSION". ULFO is its default format;-ovgoes, since the step already removes the old DMG (build-7, follow-up to build(release): build, sign and package with stock Apple tools #3512).Verified
VERSION=0.0.0-dev package.sh app --unsignedon macOS 27.0.1 wrote a ULFO image with an APFS volume namedTablePro 0.0.0-dev, holding the app and the/Applicationslink, and the DMG takes a codesign signature. shellcheck.