Repository navigation
Conversation
|
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
drdren
commented
Apr 8, 2026
drdren
left a comment
drdren
left a comment
Contributor
Author
There was a problem hiding this comment.
Try to fix pip install
drdren
commented
Apr 8, 2026
drdren
left a comment
drdren
left a comment
Contributor
Author
There was a problem hiding this comment.
Remove pip install
drdren
commented
Apr 8, 2026
drdren
left a comment
drdren
left a comment
Contributor
Author
There was a problem hiding this comment.
Add pip install pyqsp
KetpuntoG
reviewed
Apr 8, 2026
Comment on lines
+197
to
+210
| def MultiControlledZ(wires, control_values=None): | ||
| if control_values is None: | ||
| control_values = [0] * (len(wires) - 1) | ||
| qml.ctrl(qml.Z(wires=wires[-1]), | ||
| control=wires[:-1], | ||
| control_values=control_values) | ||
|
|
||
| # R_gate implements the reflection R used in the block construction. | ||
| def R(wires): | ||
| assert len(wires) % 2 == 1 | ||
| n = len(wires)//2 | ||
| qml.PauliX(wires=wires[0]) | ||
| MultiControlledZ(wires=wires[1:n+1]+[wires[0]]) | ||
| qml.PauliX(wires=wires[0]) |
Contributor
There was a problem hiding this comment.
Take a look to qml.Reflection(wires)
That should replace all this code 😄
KetpuntoG
reviewed
Apr 8, 2026
Comment on lines
+440
to
+445
| def ProjCtrlPhaseShift(control_wires, target_wire, phi): | ||
| qml.MultiControlledX(wires=control_wires + target_wire, | ||
| control_values=[0] * len(control_wires)) | ||
| qml.RZ(phi = 2 * phi, wires=target_wire) | ||
| qml.MultiControlledX(wires=control_wires + target_wire, | ||
| control_values=[0] * len(control_wires)) |
Collaborator
There was a problem hiding this comment.
I don't think they are equivalent. I tested it numerically and they both apply different phase patterns.
KetpuntoG
reviewed
Apr 8, 2026
drdren
commented
Apr 16, 2026
drdren
left a comment
drdren
left a comment
Contributor
Author
There was a problem hiding this comment.
Remove pip install pyqsp
Your preview is ready 🎉!You can view your changes here
|
drdren
commented
Apr 17, 2026
drdren
commented
Apr 17, 2026
drdren
left a comment
drdren
left a comment
Contributor
Author
There was a problem hiding this comment.
Fix figure formatting
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
Co-authored-by: drdren <104710745+drdren@users.noreply.github.com>
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
Co-authored-by: drdren <104710745+drdren@users.noreply.github.com>
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
drdren
commented
Oct 8, 2026
Co-authored-by: drdren <104710745+drdren@users.noreply.github.com>
KetpuntoG
reviewed
Oct 13, 2026
| control_values=[0])(wires=wires[:n], *args, **kwargs) | ||
|
|
||
| # Adjoint of U on the data register controlled on ancilla B=0. | ||
| def Uc_adj(base, wires, *args, **kwargs): |
Contributor
There was a problem hiding this comment.
Just leaving an on-the-fly comment: Is it necessary to manually define the adjoint of all the operators? We have qp.adjoint for this
KetpuntoG
reviewed
Oct 13, 2026
| # | ||
|
|
||
| qp.draw_mpl(be_circuit)(feature_vector, main_wires, ancilla_wires) | ||
|
|
Contributor
There was a problem hiding this comment.
if you add
plt.show()
then in the deployment we clean the output
rishabh-gupta28
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
Ensure that your tutorial executes correctly, and conforms to the
guidelines specified in the README.
Remember to do a grammar check of the content you include.
All tutorials conform to
PEP8 standards.
To auto format files, simply
pip install black, and thenrun
black -l 100 path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Title:
Summary:
Relevant references:
Possible Drawbacks:
Related GitHub Issues:
If you are writing a demonstration, please answer these questions to facilitate the marketing process.
GOALS — Why are we working on this now?
Eg. Promote a new PL feature or show a PL implementation of a recent paper.
AUDIENCE — Who is this for?
Eg. Chemistry researchers, PL educators, beginners in quantum computing.
KEYWORDS — What words should be included in the marketing post?
Which of the following types of documentation is most similar to your file?
(more details here)