Skip to content

Fix mojodbg argument parsing - #64

Merged
P403n1x87 merged 1 commit into
P403n1x87:mainfrom
cjwatson:mojodbg-argparse
Nov 9, 2026
Merged

P403n1x87 merged 1 commit into
P403n1x87:mainfrom
cjwatson:mojodbg-argparse

Conversation

@cjwatson

@cjwatson cjwatson commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Description of the Change

Fix the definition of mojodbg's "echo" option, which I think was meant to be --echo rather than echo. Without this, we get:

$ mojodbg --help
[...]
ValueError: invalid option string 'echo': must start with a character '-'

Verification Process

uv run mojodbg --help (or any other arrangement to run mojodbg) works with this patch, but fails with a traceback without it.

Without this, we get:

```
$ mojodbg --help
[...]
ValueError: invalid option string 'echo': must start with a character '-'
```
@P403n1x87

Copy link
Copy Markdown
Owner

Good catch, thanks for contributing the fix 🙇 . Just out of curiosity, is there more context to this? mojodbg is a (meta-)debugging tool: you wouldn't use it if there wasn't an issue with a MOJO file.

@P403n1x87
P403n1x87 merged commit 53a0c25 into P403n1x87:main Nov 9, 2026
17 checks passed
@cjwatson

cjwatson commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

I was packaging this for Debian (to simplify the austin packaging), and to maximize the chances of getting it through new-package review smoothly I thought I'd quickly arrange to run help2man over all the programs here. That blew up on mojodbg because of this.

@cjwatson
cjwatson deleted the mojodbg-argparse branch November 9, 2026 09:56
@P403n1x87

Copy link
Copy Markdown
Owner

I was packaging this for Debian (to simplify the austin packaging), and to maximize the chances of getting it through new-package review smoothly I thought I'd quickly arrange to run help2man over all the programs here. That blew up on mojodbg because of this.

Thanks for sharing and for looking into this and the Austin Debian packaging issue 🙇

@P403n1x87

P403n1x87 commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

@cjwatson a slightly off-topic question while I have you here, if I may: what would happen to the Debian packaging if I were to rename master into main inside the Austin repository?

@cjwatson

cjwatson commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@cjwatson a slightly off-topic question while I have you here, if I may: what would happen to the Debian packaging if I were to rename master into main inside the Austin repository?

I don't think that would affect us at all either way. If it did it would be trivial to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants