Repository navigation
feat: show progress during format conversion - #63
Merged
Merged
Conversation
Converting large profiles can take a long time with no feedback. Add a generic file_progress context manager that reports the fraction of a file read so far from a background thread, by polling the OS-level file position. This keeps presentation out of the readers and works with any of them. open_profile accepts an optional progress callback, and austin2speedscope and austin2pprof use it to show a progress line on stderr when it is a terminal, which is cleared on completion. Closes #31 Co-authored-by: Tom Sparrow <793763+sparrowt@users.noreply.github.com>
Owner
Author
|
based on #32 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 86.49% 86.40% -0.10%
==========================================
Files 22 22
Lines 3088 3118 +30
Branches 425 427 +2
==========================================
+ Hits 2671 2694 +23
- Misses 322 328 +6
- Partials 95 96 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting large profiles can take a long time with no feedback. Add a generic file_progress context manager that reports the fraction of a file read so far from a background thread, by polling the OS-level file position. This keeps presentation out of the readers and works with any of them. open_profile accepts an optional progress callback, and austin2speedscope and austin2pprof use it to show a progress line on stderr when it is a terminal, which is cleared on completion.
Closes #31