Repository navigation
Update OpenFE pin to use 1.13 and update cinnabar plot script - #176
Merged
Merged
Conversation
Contributor
Author
|
Blocked by #150 |
IAlibay
reviewed
Oct 19, 2026
jaclark5
reviewed
Oct 19, 2026
jaclark5
left a comment
jaclark5
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks like it's coming along but I see the tests didn't pass.
Since we are updating the version of OpenFE and cinnebar, _not_test_example_plot_asfe.py should be renamed _example_plot_asfe.py so that it runs in CI.
I ran locally and everything passes if in _example_plot_asfe.py the lines:
n_values = len(femap.graph.nodes)
print(f" - {system_group}/{system_name}: {n_values} calculations")are replaced with:
n_edges = femap.n_edges
print(f" - {system_group}/{system_name}: {n_edges} edges")Co-authored-by: Jennifer A Clark <jennifer.clark@omsf.io>
IAlibay
reviewed
Oct 20, 2026
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Contributor
Author
|
Possibly also supersedes #150 by updating the version of pontibus used. |
jaclark5
approved these changes
Oct 20, 2026
jaclark5
left a comment
jaclark5
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also noticed the
_no_test_example_plot_asfe.pyis using the new cinnabar (0.6 +) so we leave that script.