Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The iface section of ochami-smd(1) only described "get". Add entries for "add" and "delete", following the compep and rfe sections: their forms, the payload input options, --all and --no-confirm for delete, and the rule that delete only uses each payload item's ID (blank or path-like IDs are a usage error, and no ID is derived from MACAddress). Fixes OpenCHAMI#206 Signed-off-by: anyingiit <49945850+anyingiit@users.noreply.github.com>
synackd
force-pushed
the
docs-smd-iface-man
branch
from
October 22, 2026 23:02
283c5fe to
a8c8f3b
Compare
synackd
approved these changes
Oct 23, 2026
synackd
requested changes
Oct 23, 2026
synackd
left a comment
Collaborator
There was a problem hiding this comment.
Commits must have verified GPG/SSH signatures. Please edit your commit.
Collaborator
|
Apologies, I think the signature might have gotten messed up when I rebased. (Should have known better not to trust GitHub with that...) |
12 of 17 tasks
Collaborator
|
This is superseded by #225. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by winshyon · project thread
Fixes #206
This adds
addanddeleteentries to theifacesection ofman/ochami-smd.1.sc, which until now covered onlyget. The new entries follow the existingcompepandrfesections.comp_id mac_addr net_name,ip_addr;-d data,-d @pathand-d @-forms;-D/--descriptionoption, including its default and that it cannot be combined with-d;-f/--format-inputoption.--all, interface ID, and-dforms;--no-confirm;./..or/-containing ID is a usage error before anything is deleted;MACAddress.make manbuilds cleanly with scdoc 1.11, and the generatedochami-smd.1now listsadd,deleteandgetunderiface.Possible follow-up for
iface addWhile checking the positional form of
iface addagainst the code, I noticed two things:Usestring and--helpsay "one or more pairs of network name and IP address", and one of the examples passes two pairs.PreRunE, however, requires exactly 3 arguments (len(args) != 3), soochami smd iface add x3000c1s7b55n0 de:ca:fc:0f:fe:ee external,10.1.0.55 internal,172.16.0.55fails withexpected -d or >= 3 arguments ..., got 4.... de:ca:fc:0f:fe:ee external, panics withindex out of range [1] with length 1atcmd/smd/iface/add.go:92.The man page above documents what the command does today, which is a single
net_name,ip_addrpair. I'm happy to open a separate fix if you'd likeaddto accept multiple pairs as its help text says.The commit is signed off (DCO).
This change was prepared with AI assistance (Claude Code). I reviewed the diff and the generated man page, and I ran the commands above myself.
🤖 Generated with Claude Code