Repository navigation
Fix JDBC Resource Leaks in SQL Injection Challenges - #932
Open
LucaBonamino wants to merge 2 commits into
Open
LucaBonamino wants to merge 2 commits into
LucaBonamino wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the JDBC resource leaks reported in #931.
Several SQL Injection challenges do not properly release database connections, statements, and result sets. As a result, repeated requests can exhaust the HikariCP connection pools, causing subsequent queries to fail until Tomcat is restarted.
Changes
try-with-resourcesto ensure JDBC resources are properly closed.SQL queries fail or exceptions occur.
of the challenges.
The changes address resource management without altering the educational
purpose of the SQL Injection exercises.
Testing
After applying the fix and rebuilding the application, repeated valid and malformed SQL queries no longer exhausted the affected connection pools during local testing.
Related issue
Fixes #931