Skip to content

Label PhasorDynamics components and hierarchical lookup to support querrying - #631

Merged
nkoukpaizan merged 4 commits into
developfrom
nicholson/component-labels
Nov 2, 2026
Merged

nkoukpaizan merged 4 commits into
developfrom
nicholson/component-labels

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This adds labels for PhasorDynamics components and hierarchical lookup methods. This will be useful for querrying specific components.

Proposed changes

  • Added ComponentData::label().
  • Added recursive searching for the components (and buses and signals) in subsystems.
    • findComponent, superseding findBranch
    • findBus
    • findSignalNode calling find in SignalNodeSet
  • Added a relevant test in SubsystemModelTests.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@nkoukpaizan nkoukpaizan self-assigned this Oct 28, 2026
@nkoukpaizan nkoukpaizan added the enhancement New feature or request label Oct 28, 2026
@read-the-docs-community

read-the-docs-community Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 GridKit | 🛠️ Build #35586775 | 📁 Comparing 27ca336 against latest (9c211f3)

  🔍 Preview build  

150 files changed · + 98 added · ± 47 modified · - 5 deleted

+ Added

± Modified

- Deleted

@nkoukpaizan
nkoukpaizan marked this pull request as ready for review October 28, 2026 18:40
@nkoukpaizan
nkoukpaizan requested review from lukelowry and pelesh and removed request for lukelowry October 28, 2026 18:40
@nkoukpaizan
nkoukpaizan force-pushed the nicholson/component-labels branch from 63c425a to e432df6 Compare October 29, 2026 00:13

@lukelowry lukelowry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding and valuable!

@nkoukpaizan
nkoukpaizan force-pushed the nicholson/component-labels branch from e432df6 to 27ca336 Compare November 2, 2026 16:34
@nkoukpaizan
nkoukpaizan merged commit 5505453 into develop Nov 2, 2026
7 checks passed
@nkoukpaizan
nkoukpaizan deleted the nicholson/component-labels branch November 3, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants