Skip to content

Fix vocab home page and landing page links - #2136

Merged
UnniKohonen merged 1 commit into
mainfrom
issue2131-fix-global-url-trailing-slash
Nov 12, 2026
Merged

UnniKohonen merged 1 commit into
mainfrom
issue2131-fix-global-url-trailing-slash

Conversation

@UnniKohonen

Copy link
Copy Markdown
Contributor

Reasons for creating this PR

Links to vocab home page and Skosmos landing page on vocab/concept pages are currently broken (see #2131).

Link to relevant issue(s), if any

Description of the changes in this PR

Add a trailing slash to links leading to vocab home page and landing page.

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.6 milestone Nov 12, 2026
@UnniKohonen UnniKohonen self-assigned this Nov 12, 2026
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.98%. Comparing base (5e85665) to head (30665f1).

Files with missing lines Patch % Lines
src/controller/GlobalUrlExtension.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2136      +/-   ##
============================================
- Coverage     70.99%   70.98%   -0.02%     
  Complexity     1723     1723              
============================================
  Files            34       34              
  Lines          4479     4480       +1     
============================================
  Hits           3180     3180              
- Misses         1299     1300       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@UnniKohonen UnniKohonen moved this to In progress in Skosmos 3.x Backlog Nov 12, 2026
@UnniKohonen UnniKohonen moved this from In progress to Under review in Skosmos 3.x Backlog Nov 12, 2026
@UnniKohonen
UnniKohonen requested a review from joelit November 12, 2026 11:26

@joelit joelit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@UnniKohonen
UnniKohonen merged commit 3d045a0 into main Nov 12, 2026
17 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from Under review to Issue/PR closed in Skosmos 3.x Backlog Nov 12, 2026
@UnniKohonen
UnniKohonen deleted the issue2131-fix-global-url-trailing-slash branch November 12, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Issue/PR closed

Development

Successfully merging this pull request may close these issues.

Skosmos does not remember the content language when navigating to the vocabulary front page

2 participants