Repository navigation
Fix mappings mobile layout - #2134
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2134 +/- ##
=========================================
Coverage 70.99% 70.99%
Complexity 1723 1723
=========================================
Files 34 34
Lines 4479 4479
=========================================
Hits 3180 3180
Misses 1299 1299 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Vainonen
left a comment
There was a problem hiding this comment.
This seems to improve mobile viewing as good as possible, so looks fine time. The same fix with break-work could be applied to some other elements in the page, e. g. Skosmos widgets. I noticed that the vocabulary name is not broken with break-word. After commenting that prop-mapping-vocab should also be "broken" I am not sure if breaking URLs to two lines is a good idea. I got the screenshot with very large zoom level.
| } | ||
|
|
||
| @media (max-width: 992px) { | ||
| #concept-mappings .prop-mapping-label { |
Vainonen
left a comment
There was a problem hiding this comment.
Fine, now the overflown URIs are broken into multiple lines and this can finally be merged.

Reasons for creating this PR
Mappings are currently visually broken on mobile. Very long labels overlap with vocab names like in the attached photo (https://test.dev.finto.fi/yso/fi/page/p39593)
This PR adds a new layout for very narrow screens and makes long labels overflow to the next line.
Link to relevant issue(s), if any
Description of the changes in this PR
Addresses requirement 2.1 in #1753
Known problems or uncertainties in this PR
Not sure if breaking long labels is really the best approach but it is an improvement over the status quo.
Checklist
.sr-onlyclass, color contrast)