Skip to content

patch markdown link formatting #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothycarambat merged 3 commits into from
Aug 28, 2026
Merged

patch markdown link formatting #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef556da
patch markdown link formatting
timothycarambat Aug 28, 2026
21e30ef
cargo lint
timothycarambat Aug 28, 2026
68798e8
update test fix and edge cases
timothycarambat Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ jobs:
uses: addnab/docker-run-action@v3
with:
image: ${{ steps.docker.outputs.IMAGE }}
options: "-v ${{ github.workspace }}:${{ github.workspace }} -w ${{ github.workspace }} --platform ${{ steps.docker.outputs.PLATFORM }}"
options: "-v ${{ github.workspace }}:${{ github.workspace }} -w ${{ github.workspace }} -e CI=true --platform ${{ steps.docker.outputs.PLATFORM }}"
run: |
if echo '${{ matrix.target }}' | grep -q '-musl$'; then
apk add --no-cache openssl
Expand Down
11 changes: 4 additions & 7 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,7 @@ async fn markdown_to_typst_async(
// "#link(label(\"{}\"))[{}]", current_link_url.replace("#", ""), current_link_text
// ))
// } else {
let result = &format!(
"#link(\"{current_link_url}\")[{current_link_text}] (`{current_link_url}`)"
);
let result = &format!("#link(\"{current_link_url}\")[{current_link_text}];");
// Get the current output buffer based on context
let current_output: &mut String = if in_code_block {
&mut current_code_block
Expand Down Expand Up @@ -1172,9 +1170,8 @@ print(f"User: {user}")
assert!(result.is_ok());

let (typst_code, _) = result.unwrap();
assert!(typst_code.contains(
"#link(\"https://www.rust-lang.org/\")[Rust] (`https://www.rust-lang.org/`)"
));
assert!(typst_code.contains("#link(\"https://www.rust-lang.org/\")[Rust]"));
assert!(!typst_code.contains("(`https://www.rust-lang.org/`)"));
}

#[test]
Expand Down Expand Up @@ -2156,7 +2153,7 @@ This is a new paragraph with <u>underlined text."#;

let (typst_code, _) = result.unwrap();

assert!(typst_code.contains(r#"+ Third item with #link("http://test.com")[link with \*\*bold inside] (`http://test.com`) and \*italic not closed"#));
assert!(typst_code.contains(r#"+ Third item with #link("http://test.com")[link with \*\*bold inside]; and \*italic not closed"#));
assert!(typst_code.contains(
"+ Second item with #strong[markdown bold and #emph[HTML em]] but em not closed"
));
Expand Down
Loading