Repository navigation
Skip a lone CR in readLine() instead of grabbing the next byte - #236
Merged
Merged
Conversation
After a CR that is not followed by LF, readStringTo() appended the following character without looking at it. At the end of the file that character was EOFC, so readLine()/readString() on "abc\r" returned "abc\xFF". Re-check the current character instead: LF and CRLF end the line, a lone CR is skipped, EOF ends the line with no extra byte. Add tests/test-010_read-line-cr covering string and file streams. Bump version to 0.9.49. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a CR that is not followed by LF, readStringTo() appended the following character without looking at it. At the end of the file that character was EOFC, so readLine()/readString() on "abc\r" returned "abc\xFF". Re-check the current character instead: LF and CRLF end the line, a lone CR is skipped, EOF ends the line with no extra byte.
Add tests/test-010_read-line-cr covering string and file streams. Bump version to 0.9.49.