Repository navigation
feat(spotify): import liked songs from exports or OAuth PKCE - #4445
Draft
notgamermx wants to merge 1 commit into
Draft
notgamermx wants to merge 1 commit into
notgamermx wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft proposal: the README and PR template currently state that Metrolist is in a feature freeze. This is a standalone Spotify import proposal for maintainer consideration; it is not presented as an approved feature or ready to merge.
Problem
Users migrating from Spotify currently have to find and like their saved songs individually in Metrolist.
Cause
Settings has no importer for Spotify liked-library metadata.
Solution
user-library-read) using the external browser, a loopback callback with state validation, and encrypted token storage undernoBackupFilesDirusing Android Keystore. No client secret is required.Direct OAuth requires the user's own Spotify developer app and is subject to Spotify development-mode eligibility. The callback follows Spotify's loopback redirect guidance. File import remains the fallback.
Testing
:app:assembleFossDebug,:app:testFossDebugUnitTestand:innertube:testpassed with JDK 21.CodeRabbit CLI reviewed this patch before the PR. Its first review reported three issues: blocking network cancellation, accepting a callback without a code/error, and rejecting an entire export for one oversized metadata row. All three were fixed and regression coverage added. Final CodeRabbit result: 0 findings across all 13 files.
Live Spotify authorization, real-device UI testing and an end-to-end migration have not been performed on this isolated branch. No personal exports, credentials, signing keys or APKs are included.
Related Issues
No linked or previously approved feature issue.