Skip to content

fix(playback): bump InnerTubeX to v0.8.4 - #4436

Merged
nyxiereal merged 1 commit into
mainfrom
fix/bump-innertubex-v0.8.4
Oct 8, 2026
Merged

nyxiereal merged 1 commit into
mainfrom
fix/bump-innertubex-v0.8.4

Conversation

@nyxiereal

@nyxiereal nyxiereal commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Problem

  • Tracks on multi-language uploads (e.g. kids channels with dubbed audio) could fail to play, or play a dubbed language instead of the original.
  • The Web Embedded fallback client never returned a playable response for a session with a saved visitor.

Cause

  • InnerTubeX picked the highest-bitrate audio format without looking at audio tracks, so a dub could outrank the original.
  • Embed-page encryptedHostFlags only work with the visitor that fetched the embed page, but InnerTubeX sent the session's saved visitor instead.

Solution

  • Bump InnerTubeX from v0.7.4 to v0.8.4. v0.8.4 picks the original audio track (falling back to the default track) and sends the embed page visitor with the embed flags.
  • This also brings in the v0.8.0 changes: lower EJS/QuickJS memory use and streamed config pages. Kotlin callers stay source compatible.

Testing

  • ./gradlew :app:assembleDebug builds against the JitPack v0.8.4 artifact.
  • Both library fixes have regression tests in InnerTubeX, and were checked on a device through Metrolist-KMP: kids tracks on AUTO and WEB_REMIX_SABR, and WEB_EMBEDDED_PLAYER, went from failing to passing 90 s playback with seeks and paused preload, with no regressions across the other clients.
  • Not yet tested on a device in this app.

Related Issues

  • Related to MetrolistGroup/innertubex v0.8.4

Summary by CodeRabbit

  • Maintenance
    • No user-facing changes are included in this release. Visible features, interface elements, and existing workflows remain unchanged. No new functionality or user-facing fixes are reported. There are no changes to how the app is used.

RetriggerConfidence Score: 5/5

The dependency update appears safe to merge; no blocking defect was found.

Summary

Updates InnerTubeX from v0.7.4 to v0.8.4 in gradle/libs.versions.toml.

  • Intended to fix original-audio selection and embedded playback with a saved visitor.
  • No actionable issues were found in the changed code.
  • This review did not run a build or device playback test.

Reviews (1) · Last reviewed commit: "fix(playback): bump InnerTubeX to v0.8.4" · Reviewed by Greptile

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T15:19:03.819850Z 1a615c2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 98b7abdb-90a1-4253-b57e-ff70dc49f1d5
📥 Commits

Reviewing files that changed from the base of the PR and between fe33568 and 1a615c2.

📒 Files selected for processing (1)
  • gradle/libs.versions.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The version catalog updates innertubex from v0.7.4 to v0.8.4.

Changes

Dependency version update

Layer / File(s) Summary
Update innertubex version
gradle/libs.versions.toml
The version catalog changes innertubex from v0.7.4 to v0.8.4.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1a615

No actionable merge-blocking issue is established by the version update; it appears ready to merge after normal project checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description includes all required sections. It clearly explains the playback problems, root causes, dependency update, testing results, and related work. It also states that device testing in this…
Title check ✅ Passed The title is concise and accurately identifies the playback fix and the InnerTubeX dependency update to v0.8.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nyxiereal
nyxiereal merged commit b989947 into main Oct 8, 2026
3 checks passed
@nyxiereal
nyxiereal deleted the fix/bump-innertubex-v0.8.4 branch October 8, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant