Skip to content

chore!: require Node ≥24.22.1 - #444

Merged
jvbriones merged 5 commits into
mainfrom
chore/modernize-node-ci
Nov 5, 2026
Merged

jvbriones merged 5 commits into
mainfrom
chore/modernize-node-ci

Conversation

@jvbriones

@jvbriones jvbriones commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Modernize the development toolchain and CI, and add smoke tests for production artifacts.

  • Require Node ≥24.22.1, with development and CI pinned to 24.22.2.
  • Keep Yarn 1.22.22 and verify toolchain versions in CI.
  • Update checkout/setup-node to SHA-pinned v6 references.
  • Restrict CI permissions, disable persisted checkout credentials, add timeouts, and remove duplicate lint execution.
  • Add dependency-free smoke tests for production pages, referenced local assets, valid JSON, and missing routes.
  • Update setup and testing documentation.

Breaking change
Node 20 and 22 are no longer supported. Consumers installing future releases must use Node ≥24.22.1.

No wallet code, dependency versions, lockfile, or deployment behavior changed.

Manual test
built JavaScript → browser → MetaMask → response back to the dapp

Screen.Recording.2026-11-03.at.10.26.31.mov

@jvbriones
jvbriones requested a review from a team as a code owner November 1, 2026 14:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T14:54:05.761362Z e789373 PR opened
🔒 Security Review ✅ Completed 2026-11-01T14:54:41.507769Z e789373 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread scripts/smoke-test.js Fixed
@jvbriones jvbriones changed the title chore: modernize development toolchain chore!: require Node ≥24.22.1 Nov 3, 2026
@jvbriones
jvbriones enabled auto-merge (squash) November 3, 2026 10:02
@jvbriones
jvbriones disabled auto-merge November 5, 2026 09:28
@jvbriones
jvbriones enabled auto-merge (squash) November 5, 2026 09:29
@jvbriones
jvbriones merged commit 70c913a into main Nov 5, 2026
5 checks passed
@jvbriones
jvbriones deleted the chore/modernize-node-ci branch November 5, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants