Skip to content

ci: add the Approved-by trailer to squash merges - #1901

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/approved-by-trailer/add-approved-trailer-squash-merges--dea5f080
Oct 17, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/approved-by-trailer/add-approved-trailer-squash-merges--dea5f080

Conversation

@jd

@jd jd commented Oct 16, 2026

Copy link
Copy Markdown
Member

The default queue rule squashes with the pull request's title and body.
It now also lists approved-by under trailers, so each squash commit
names the reviewers who approved the pull request, one
Approved-by: line per reviewer.

The dependencies rule merges by fast-forward, which keeps the original
commits, so it is left as is.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

The default queue rule squashes with the pull request's title and body.
It now also lists `approved-by` under `trailers`, so each squash commit
names the reviewers who approved the pull request, one
`Approved-by:` line per reviewer.

The dependencies rule merges by fast-forward, which keeps the original
commits, so it is left as is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Change-Id: Idea5f080205d19ee03e73155394ff504d1d9867d
Copilot AI balanced review requested due to automatic review settings October 16, 2026 21:59
@mergify
mergify Bot deployed to Mergify Merge Protections October 16, 2026 21:59 Active
@mergify
mergify Bot requested a review from a team October 16, 2026 21:59
@mergify

mergify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 📃 Configuration Change Requirements

Mergify configuration change

  • any of:
    • check-success = @mergify/Configuration changed
    • check-success = @mergify/Configuration has been deleted

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=1
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@jd
jd marked this pull request as ready for review October 17, 2026 08:34
@mergify

mergify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-10-17 08:49 UTC · Rule: default · triggered by merge protections
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-10-17 08:49 UTC · at 459abbca905018eafa34d73a0c3bd34fee086069 · squash

This pull request spent 8 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Oct 17, 2026
@mergify
mergify Bot merged commit 459abbc into main Oct 17, 2026
5 of 6 checks passed
@mergify
mergify Bot deleted the devs/jd/jd/approved-by-trailer/add-approved-trailer-squash-merges--dea5f080 branch October 17, 2026 08:49
@mergify mergify Bot removed the queued label Oct 17, 2026

This branch was successfully deployed

1 active deployment
Mergify Merge Protections — 0f887420 Deployed Oct 16, 2026 by mergify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants