Repository navigation
Conversation
db_schema_diagnostic() requested servers/schemaDiagnostics, which does not exist. ServersController defines the action as dbSchemaDiagnostic() (app/Controller/ServersController.php:2604), and PyMISP calls the same path (pymisp/api.py:389: 'servers/dbSchemaDiagnostic'). Update the client to GET servers/dbSchemaDiagnostic, and correct/add the wiremock test that previously would have encoded the wrong path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JoSButbVaWEtGMXwTx73BZ
elhoim
marked this pull request as draft
September 3, 2026 05:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLUF —
db_schema_diagnosticcalls a nonexistent server action, so the diagnostic never runs.db_schema_diagnostic()insrc/client.rsissuedGET servers/schemaDiagnostics, which is not a MISP action;ServersControllerdefinesdbSchemaDiagnostic(), so the call yields a MissingAction rather than schema data.GET servers/dbSchemaDiagnostic, matching the controller and PyMISP, and adds the first test for this method,db_schema_diagnostic_hits_correct_action.test_event_crud_lifecycleraced the publish worker), fixed in PR fix: [ci] Run integration tests on ubuntu-24.04 to match php8.3 #53 and unrelated to this PR.Finding
db_schema_diagnostic calls servers/schemaDiagnostics; action is dbSchemaDiagnostic
ServersController defines dbSchemaDiagnostic(). MissingAction.
Change
db_schema_diagnostic() in src/client.rs called GET servers/schemaDiagnostics, which is not a real MISP action. ServersController defines the action as dbSchemaDiagnostic() (a GET-accessible, non-POST-restricted REST action), and PyMISP's db_schema_diagnostic() confirms the wire path is servers/dbSchemaDiagnostic. Changed the client to GET servers/dbSchemaDiagnostic and added a wiremock unit test asserting the correct path (no prior test covered this method, so nothing needed correcting — a new test was added).
Upstream evidence
MISP core app/Controller/ServersController.php:2604 (
public function dbSchemaDiagnostic(), REST-accessible via$this->RestResponse->viewData(...)at line 2608, no POST-only guard like the neighboring changeLockState action); PyMISP pymisp/api.py:389 (response = self._prepare_request('GET', 'servers/dbSchemaDiagnostic')).Verified against MISP core
843b6744and PyMISPe7debb4f.Tests
db_schema_diagnostic_hits_correct_action (src/client.rs, wiremock unit test asserting GET /servers/dbSchemaDiagnostic)Verified locally:
cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings,cargo test --all-features --lib,--test integration_tests --no-run, andcargo check --examples, each in an isolated target directory.🤖 Generated with Claude Code